Skip to content

Add teach-ai-launch-2023 dcdo flag - #51444

Merged
kelbyhawn merged 1 commit into
stagingfrom
ai-launch-2023-dcdo-flag
Apr 20, 2023
Merged

Add teach-ai-launch-2023 dcdo flag#51444
kelbyhawn merged 1 commit into
stagingfrom
ai-launch-2023-dcdo-flag

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

Adding the teach-ai-launch-2023 DCDO flag preemptively to use on upcoming PRs.

Related PRs:


@kelbyhawn
kelbyhawn requested a review from a team April 20, 2023 20:12
@kelbyhawn
kelbyhawn merged commit b5e1b9f into staging Apr 20, 2023
@kelbyhawn
kelbyhawn deleted the ai-launch-2023-dcdo-flag branch April 20, 2023 22:24
@megcrenshaw

Copy link
Copy Markdown

I think we need to manually add this flag, as I don't see it in our table
image

Is it clear who is doing that and when?

When I needed to do this for contact rollups, I added instructions in this doc about it.

@kelbyhawn

Copy link
Copy Markdown
Contributor Author

I think we need to manually add this flag, as I don't see it in our table…

Interesting, I've never added a DCDO flag in AWS, but I see other ones I've made in that table 🤔 Maybe they get added automatically once it's set on production?

@davidsbailey

Copy link
Copy Markdown
Member

I think the way DCDO flags changed some time semi-recently. @Hamms am I correct in remembering that you no longer just run DCDO.set ... from the rails console to set these flags?

@megcrenshaw

megcrenshaw commented Apr 25, 2023

Copy link
Copy Markdown

This is what I'm seeing locally –– it does look like you need to run DCDO.set(...) but the second argument for get is the value if the flag is not set

When I set a DCDO flag to true, the get returns true regardless of the second argument.

[development] dashboard > DCDO.set('contact_rollups_active', true)
=> []
[development] dashboard > DCDO.get('contact_rollups_active', true)
=> true
[development] dashboard > DCDO.get('contact_rollups_active', false)
=> true

When I set a DCDO flag to false, the get returns false regardless of the second argument.

[development] dashboard > DCDO.set('contact_rollups_active', false)
=> []
[development] dashboard > DCDO.get('contact_rollups_active', false)
=> false
[development] dashboard > DCDO.get('contact_rollups_active', true)
=> false

When I make up a bogus flag without using set, the second get argument is used

[development] dashboard > DCDO.get('test', true)
=> true
[development] dashboard > DCDO.get('test', "false")
=> "false"
[development] dashboard > DCDO.get('test', false)
=> false
[development] dashboard > DCDO.get('test', 8)
=> 8

I think all of this means that one of us needs to run DCDO.set() to get this in prod.

@kelbyhawn

Copy link
Copy Markdown
Contributor Author

I think all of this means that one of us needs to run DCDO.set() to get this in prod.

Yep! I've set DCDO flags before and plan to set this one live on production (and staging) next Tuesday morning once the embargo lifts — not sure if you can see it, but here's my Asana task.

@megcrenshaw

Copy link
Copy Markdown

I think all of this means that one of us needs to run DCDO.set() to get this in prod.

Yep! I've set DCDO flags before and plan to set this one live on production (and staging) next Tuesday morning once the embargo lifts — not sure if you can see it, but here's my Asana task.

Ah, I missed that you were already planning to do that! Sounds great 👍

@davidsbailey

Copy link
Copy Markdown
Member

I think it might work differently in different environments now, but at least it looks like flags in prod are still set in the way you are describing as of quite recently: https://codedotorg.slack.com/archives/C03CK49G9/p1680642353499039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants