Remove Unused signup_error_messages! Helper - #51424
Merged
Merged
Conversation
This used to be an overridable method in Devise, but has long since been deprecated, first in favor of `devise_error_messages!` and then in favor of the `devise/shared/error_messages` partial. Fortunately, we have also long since stopped using it. Also remove some associated i18n strings which are similarly unused. - https://github.com/heartcombo/devise/blob/v4.7.0/app/helpers/devise_helper.rb
nicklathe
approved these changes
Apr 20, 2023
nicklathe
left a comment
nicklathe
left a comment
Contributor
There was a problem hiding this comment.
I don't have the historical context with this how/where this method was being used, but looks good to me in regard to removing it and the related i18n messages. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to be an overridable method in Devise, but has long since been deprecated, first in favor of
devise_error_messages!and then in favor of thedevise/shared/error_messagespartial. Fortunately, we have also long since stopped using it.Also remove some associated i18n strings which are similarly unused.
Links
Testing story
Grepped the codebase for instances of
additional_informationandnot_savedto verify that we aren't using these strings anywhere else. Tested out a few different ways to generate error messages in the signup workflow locally to verify that everything still works. Otherwise, relying on existing tests to verify that this doesn't represent any change in functionality.