[CFU] Add eyes tests for summary view - #51414
Conversation
hannahbergam
left a comment
hannahbergam
left a comment
There was a problem hiding this comment.
The difference between ui and eyes test is this funky wording that I think you still need to add here. An example:
@eyes
Scenario: Stage Locking Dialog
Given I create an authorized teacher-associated student named "bobby"
When I open my eyes to test "stage locking"
...
And I see no difference for "selected section"
...
And I see no difference for "stage lock dialog"
...
And I see no difference for "course overview for authorized teacher"
And I close my eyes
I think 'I see no difference' is the actual baseline check!
|
🤯 thanks! i didn't realize that's what those were doing |
|
Is there any way to test the eyes part without deploying? |
|
@rshipp you can follow the directions at https://github.com/code-dot-org/code-dot-org/blob/staging/docs/testing-with-applitools-eyes.md to see the baselines that will be generated |
| @eyes | ||
| Feature: Level summary | ||
|
|
||
| Scenario: Free Response level 1 |
There was a problem hiding this comment.
At the beginning of eyes tests, you need a line like When I open my eyes to test "Free Response Level Summary", like in this test
| And I see no difference for "level summary" | ||
| And I close my eyes | ||
|
|
||
| Scenario: Free Response level 2 |
There was a problem hiding this comment.
What's the difference between level 1, level 2, and level 3. Do we need all three?
There was a problem hiding this comment.
I picked these 3 because one has a level.title that gets rendered as an h1, one has no level.title but an h2 in the markdown, and one has no heading at all. i expect some heading differences with my next PR because of the application.css styles, and wanted to be sure to have baselines for that. the first allthethings also has more features used than the other 2, like the teacher instructions. other than that, I don't know what the best way to test this stuff is. it doesn't feel great to have such a wide variety of content in these levels with no way to find example levels that use each feature, I've just been asking Bryan or stumbling across levels by accident that have new things i've never seen before
hannahbergam
left a comment
hannahbergam
left a comment
There was a problem hiding this comment.
LGTM! I'm way less well-versed on how to update the allthethings script, but as long as it's still passing all the other tests then I say ✅
| Then I see no difference for "free response level summary 2" | ||
| And I close my eyes | ||
|
|
||
| Scenario: Free Response level 3 |
There was a problem hiding this comment.
Yay! Good work covering several different views.
This reverts commit a2b009f.
3 participants
Add some feature tests for the summary view on a few Free Response levels, so we can collect visual baselines in advance of refactoring.
Since I just want the visual diffs, I didn't have any specific test cases in mind; open to feedback on whether I should add some
verifysteps or something to these.Ran locally:
