Add resources to collections lessons that were missing them - #51359
Merged
Conversation
bethanyaconnor
marked this pull request as ready for review
April 14, 2023 21:03
hannahbergam
approved these changes
Apr 14, 2023
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Spot checked several of the diffs and ✅
| } | ||
| } | ||
| ], | ||
| "lessons_resources": [ |
Contributor
There was a problem hiding this comment.
Confirmed that this is represented later!
| "scripts_student_resources": [ | ||
|
|
||
| ], | ||
| "vocabularies": [ |
Contributor
There was a problem hiding this comment.
ditto for checking these too- I'm convinced they're all properly accounted for!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some lessons in collections were missing resources. Very long conversation here. I wrote a script to copy all of the resources and vocabulary over from the units in the CSD courses to their respective lessons in collections. Dan and Angelina did a spot check of pairs of lessons I used and gave it a 👍
I'd love a quick review to make sure I'm only affecting
resources,lessons_resources,vocabularies, andlesson_vocabularies(andserialized_at). Anything else would be unintentional.Note: some of the resource markdown didn't get updated correctly here even though I tried to update it. This should be solved by https://codedotorg.atlassian.net/browse/TEACH-395, so I elected to not worry about it here.
Code used to do copy these over. This looks like a lot but it's mostly copied from Lesson.copy_to_unit