Turning on Samoan in production - #51354
Merged
Merged
Conversation
daynew
approved these changes
Apr 14, 2023
daynew
left a comment
daynew
left a comment
Member
There was a problem hiding this comment.
Another task after this is merged is to also update cdo-languages.csv and then merge a manual change on staging for pegasus/data/cdo-languages.csv, right?
Contributor
Author
|
Updating the Google sheet should trigger those changes in the next staging build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samoan was recently added to supported languages.
After turning off the supported flags in
cdo-languagesGoogle sheet, a unit tests began to fail, blocking our deployment pipeline.The unit tests failing was
test_i18n_hoc_routes.rbthe test failed because there wasn't a
pegasus/sites.v3/hourofcode.com/i18n/sm.ymlfileAfter samoan was added to the sync, etags where correctly created for the new language, but hour of code files were not committed, resulting in an incomplete sync.
This PR manually adds
sm.ymlto thepegasus/sites.v3/hourofcode.com/i18ndirectory to unblock the failing test.Additionally, this PR removes the Debug flag for samoan in
locales.ymlLinks
Testing story
Ran a mini sync to test that
hourofcodefiles for samoan where synced down and out.I locally ran the
test_i18n_hoc_routes.rband successfully passed.