Skip to content

Remove references to @no-ie tag - #51350

Merged
fisher-alice merged 3 commits into
stagingfrom
alice/cleanup-noie-tags
Apr 17, 2023
Merged

Remove references to @no-ie tag#51350
fisher-alice merged 3 commits into
stagingfrom
alice/cleanup-noie-tags

Conversation

@fisher-alice

@fisher-alice fisher-alice commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

This PR removes the @no-ie tag and references to it.

We stopped testing Internet Explorer with this PR in early 2022. In this PR, @cat5inthecradle wrote:

Not removing IE references from
- test cases with @eyes_ie or @no_ie annotations
- assertions of IE compatability in "activity-guidelines" or other documents
We recommend that teams spend some time searching for any cleanup opportunities.

This PR removes IE references from test cases with @no_ie and @eyes_ie. It also removes test-related references to IE. There are still dozens of references to 'Internet Explorer' remaining in the code base that are not related to testing. For example, here.

Links

jira ticket - This is a follow-up to this PR which updated a flaky UI test.

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice
fisher-alice marked this pull request as ready for review April 14, 2023 19:42
@fisher-alice
fisher-alice requested review from a team and cat5inthecradle April 14, 2023 19:42

@bencodeorg bencodeorg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@fisher-alice
fisher-alice merged commit 062d9ef into staging Apr 17, 2023
@fisher-alice
fisher-alice deleted the alice/cleanup-noie-tags branch April 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants