Turn on TypeScript linting and fix errors - #51346
Merged
Merged
Conversation
breville
reviewed
Apr 14, 2023
| "scripts": { | ||
| "lint": "yarn lint:scss && yarn lint:js", | ||
| "lint:js": "eslint --format ./.eslintCustomMessagesFormatter.js --ext .js,.jsx src test --resolve-plugins-relative-to .", | ||
| "lint:js": "eslint --format ./.eslintCustomMessagesFormatter.js --ext .js,.jsx,.ts,.tsx src test --resolve-plugins-relative-to .", |
breville
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable TS linting and fix outstanding violations (all in music lab). For now, we've disabled the
no-var-requiresrule, which would have flagged all uses ofrequire()to include JS files. We can fix this by just adding'allowJs': trueto ourtsconfigfile, and change the requires to imports, but adding allowJs is currently causing some build errors. I've created a task to investigate those as a follow-up: https://codedotorg.atlassian.net/browse/SL-791.Links
https://codedotorg.atlassian.net/browse/SL-763
Testing story
Tested locally; confirmed no linter errors appeared, and that the pre-commit hook correctly identified TS linter violations