[Rebranding] Fix styling issues in typography.scss - #51345
Merged
Conversation
kelbyhawn
approved these changes
Apr 14, 2023
kelbyhawn
left a comment
kelbyhawn
left a comment
Contributor
There was a problem hiding this comment.
Looks great — thanks @levadadenys!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Rebranding] Fix styling issues in typography.scss
Looks like our styleint/eslint doesn't check shared/css folder.
Since we're going to store a copy of this file in
dashboard/appsfor now and indsco_in the near future - we plan to keep both copies of this file as much synced up as it possible.This PR should make any visual different, only fixing linter issues.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: