Skip to content

Add feedback banner under progress table - #51340

Merged
dju90 merged 5 commits into
stagingfrom
share-feedback-on-progress-view
Apr 19, 2023
Merged

Add feedback banner under progress table#51340
dju90 merged 5 commits into
stagingfrom
share-feedback-on-progress-view

Conversation

@dju90

@dju90 dju90 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Links

Testing story

Tested locally
image

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dju90
dju90 marked this pull request as ready for review April 19, 2023 06:50
@dju90
dju90 requested a review from a team April 19, 2023 06:50
Comment thread apps/src/redux/rtlRedux.js Outdated
@@ -0,0 +1,25 @@
// Action type constants

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use apps/src/code-studio/isRtlRedux.js for this?

@rshipp rshipp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@dju90
dju90 merged commit 409eec4 into staging Apr 19, 2023
@dju90
dju90 deleted the share-feedback-on-progress-view branch April 19, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants