Skip to content

Add whether section is selected to amplitude event - #51318

Merged
dju90 merged 2 commits into
stagingfrom
check-section-amplitude-cfu
Apr 13, 2023
Merged

Add whether section is selected to amplitude event#51318
dju90 merged 2 commits into
stagingfrom
check-section-amplitude-cfu

Conversation

@dju90

@dju90 dju90 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dju90
dju90 requested a review from bethanyaconnor April 13, 2023 18:50
Comment thread apps/src/templates/levelSummary/CheckForUnderstanding.jsx Outdated
@dju90
dju90 merged commit 9bf8dd7 into staging Apr 13, 2023
@dju90
dju90 deleted the check-section-amplitude-cfu branch April 13, 2023 23:22
@dju90

dju90 commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

@bethanyaconnor All of the current amplitude events are logging false for this parameter. I tested it on staging with a section selected...and the value was false in the network tab. I'm wondering if the page load event is firing before selectedSection has a value...? But the sectionParam const seems to be working to preserve the sectionId when a teacher clicks the "back to level" or "next level" links, and that const references the selectedSection prop...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants