Updates to reset progress on mc lesson before testing certificate. - #51308
Merged
Conversation
This should fix the flaky test which sometimes races other tests to generate a certificate. Without resetting, a cached certificate is used. In general, this may be a bug with certificate generation since even in production the cached certificate is used even if a student enters a new name. There may be reasons for this behavior, however. These additional steps preceding the normal test will work in the presence of this caching behavior and still work if there is no cached certificate.
wilkie
marked this pull request as ready for review
April 20, 2023 15:58
mgc1194
approved these changes
Apr 20, 2023
mgc1194
left a comment
mgc1194
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I agree there may be a bug with the cache. There are some other bugs related to certificate, so I appreciate that the test will still be relevant and working when changes are made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the flaky test which sometimes races other tests to generate a certificate. Without resetting, a cached certificate is used. In general, this may be a bug with certificate generation since even in production the cached certificate is used even if a student enters a new name.
There may be reasons for this behavior, however. These additional steps preceding the normal test will work in the presence of this caching behavior and still work if there is no cached certificate. We are not trying to correct that behavior, just handle it in a way that still works if somebody does correct it later.
Warning!!
The AP CSP Create Performance Task is in progress from April 1 - May 1 2023. Please
consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org
students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game
Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking
anything in these two labs. Even small changes, such as a different button color, are considered
significant during this time period. Reach out to the Student Learning team or Curriculum team for
more details.
Links
Testing story
Ran the test suite a few times to see if it would have a flaky failure.
PR Checklist: