Refactoring and simplifying CQA table, updating icons - #51303
Merged
Conversation
hannahbergam
commented
Apr 12, 2023
| updateSection('course', {}); | ||
| if (marketingAudience !== '') { | ||
| setMarketingAudience(''); | ||
| setSelectedCourseOffering(null); |
Contributor
Author
There was a problem hiding this comment.
This is (1) from PR description
hannahbergam
commented
Apr 12, 2023
| marketingAudience, | ||
| updateMarketingAudience | ||
| }) { | ||
| // Determines which icon to render for each audience |
hannahbergam
commented
Apr 12, 2023
| }) { | ||
| // Determines which icon to render for each audience | ||
| const marketingAudienceIcon = audience => { | ||
| return marketingAudience === audience ? 'caret-down' : 'caret-right'; |
hannahbergam
commented
Apr 12, 2023
| // Otherwise, set to this audience | ||
| const determineMarketingAudience = newAudience => { | ||
| if (newAudience === marketingAudience) { | ||
| updateMarketingAudience(''); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr covers three updates. I did them together because they're all small and cover the same area.
New icon status:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: