[A11Y-77] Remove __useDeprecatedTag usage from TeacherDashboardHeader.jsx - #51295
Merged
Conversation
levadadenys
marked this pull request as ready for review
April 12, 2023 16:56
levadadenys
changed the title
molly-moen
reviewed
Apr 12, 2023
| }, | ||
| buttonWithMargin: { | ||
| marginRight: '5px' | ||
| margin: 0, |
Contributor
There was a problem hiding this comment.
what's the reason for this change?
Contributor
Author
There was a problem hiding this comment.
Glad you asked! Since it'll be button instead of a div it'll have margin: 5px; style from application.scss button base style. This line is needed to overwrite base style and keep the button appearance be the same it was before changing div to button
molly-moen
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[A11Y-77] Remove __useDeprecatedTag usage from TeacherDashboardHeader.jsx
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: