DTT (Staging > Test) [robo-dtt] - #51276
Merged
Merged
Conversation
Currently, the extra functionality `prepend`ed onto these classes by initializer logic is only applied once when the application configuration is initially loaded. This works fine in most environments, but in environments in which we want to be able to reload code on the fly (currently only `development`) this means that the modifications are lost after reload. To fix, we hook the `prepend` call itself into the `to_prepare` event, which explicitly runs once per code reload in environments which support code reloading, and only once during initial load otherwise. - https://guides.rubyonrails.org/configuring.html#initialization-events - https://stackoverflow.com/questions/8895103/how-can-i-keep-my-initializer-configuration-from-being-lost-in-development-mode
* create typography.scss file * import typography.scss file into design-system-pegasus stylsheet * update class names on existing pages * update comments * add figcaption styles * update comments * refactor mixins and classes * add more comments * update comments * update caption comment * add imports and refactor some styles * move mixin styles includes above specific styles
Apply Initializer Prepends on Each Code Reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.