Update Remaining Instances of "last argument as parameters" For Ruby 3.0 - #51271
Merged
Conversation
Hamms
added
the
Ruby Update
Hamms
changed the title
Hamms
marked this pull request as ready for review
June 7, 2023 23:56
cat5inthecradle
approved these changes
Jun 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all remaining places in the code where we are still relying on the pre-Ruby-3 behavior of automatically converting the final argument of a method call to keyword parameters.
Instances identified by running the CI build on Ruby 3 and seeing what breaks. See #49447 for more context