Restrict to only English videos on the level video editor - #51270
Merged
Conversation
hannahbergam
approved these changes
Apr 20, 2023
hannahbergam
left a comment
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
Thank you for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue report in Slack. I tested locally and could repro before this fix and could not after.
Some background on videos: videos have a
keywhich is used to link the video to the level. All videos have an English version (localecolumn =en-US) but some videos are localized into different languages. In those cases, they share the samekeyas their English counterpart with thelocalevalue equal to the language they're localized into.In this specific case, we are grouping videos by
key, which overwrites the English video info with non-English video info sometimes. This isn't causing any major issues, but a 17 comment Slack thread seems like it's confusing enough that we should fix it.