Skip to content

Disable cache_classes in the Test Environment (when using Spring) - #51256

Merged
Hamms merged 3 commits into
stagingfrom
disable-cache_classes-in-test
Apr 12, 2023
Merged

Disable cache_classes in the Test Environment (when using Spring)#51256
Hamms merged 3 commits into
stagingfrom
disable-cache_classes-in-test

Conversation

@Hamms

@Hamms Hamms commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

To enable fast code reloading in the test environment, as recommended in Rails when using Spring: https://guides.rubyonrails.org/configuring.html#config-cache-classes

Also, as of Spring 3.x, required to be able to run tests locally in development with spring testunit

Follow-up to #51255, which fixes some bugs in environments with code reloading enabled.

Links

See slack thread at https://codedotorg.slack.com/archives/C0T10HG6N/p1681166502633419 for more context

Testing story

Tested locally that this reenables running unit tests locally with spring testunit after the upgrade to Spring 3.x, and again makes it possible to run dashboard-console in the test environment.

Hamms added 2 commits April 10, 2023 18:23
As recommended in Rails when using Spring: https://guides.rubyonrails.org/configuring.html#config-cache-classes

Also, as of Spring 3.x, required to be able to run tests locally in development with `spring testunit`
@Hamms
Hamms marked this pull request as ready for review April 11, 2023 18:19
@Hamms
Hamms requested review from a team April 11, 2023 18:19

@davidsbailey davidsbailey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wahoo!
image

@Hamms Hamms changed the title Disable cache_classes in the Test Environment Disable cache_classes in the Test Environment (when using Spring) Apr 11, 2023
@Hamms
Hamms merged commit 8549421 into staging Apr 12, 2023
@Hamms
Hamms deleted the disable-cache_classes-in-test branch April 12, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants