Migrate last slice of javalab redux to redux-toolkit - #51246
Merged
Conversation
levadadenys
reviewed
Apr 11, 2023
levadadenys
left a comment
levadadenys
left a comment
Contributor
There was a problem hiding this comment.
1 minor comment, other than that LGTM!
| isTesting: boolean; | ||
| backpackEnabled: boolean; | ||
| isStartMode: boolean; | ||
| levelName: string | undefined; |
Contributor
There was a problem hiding this comment.
Can be simplified to levelName?: string
Contributor
There was a problem hiding this comment.
IMO string | undefined might be clearer just so you have to explicitly assign levelName to undefined in the initial state, rather than omitting it?
Contributor
Author
There was a problem hiding this comment.
yeah I think I'll leave it as-is so it's defined in initialState
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of the last slice of the java lab redux state to redux-toolkit. I also ran the typescript linter on the previous slices I created and fixed a couple issues there. There is no functionality change here.
Links
Testing story
Tested locally
PR Checklist: