Add CSA Summer Capstone subject and emails - #51219
Merged
Merged
Conversation
TurnerRiley
changed the base branch from
staging
to
update-enrollment-workshop-emails
April 7, 2023 21:33
TurnerRiley
changed the base branch from
update-enrollment-workshop-emails
to
staging
April 10, 2023 16:29
| def pre_survey? | ||
| # CSP for returning teachers does not have a pre-survey. | ||
| return false if subject == SUBJECT_CSP_FOR_RETURNING_TEACHERS | ||
| return false if [SUBJECT_CSP_FOR_RETURNING_TEACHERS, SUBJECT_CSA_CAPSTONE].include?(subject) |
Member
There was a problem hiding this comment.
the comment looks out of date now. I think you can safely remove the comment, since the code looks perfectly self-documenting
| - if @is_first_pre_survey_email | ||
| Please take a moment to review the following logistical details about your workshop. | ||
| - else | ||
| If you have not already done so, please review the following logistical details about your workshop. |
Member
There was a problem hiding this comment.
will this affect only the capstone reminder emails, or others too?
Contributor
Author
There was a problem hiding this comment.
Oh thank you for mentioning this I meant to leave a comment here. This will affect other emails as well but I checked with Dani on whether this should just be for the capstone or for all of them and she said we should unify it for all of them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the CSA Capstone subject to the CSA course and adds the associated enrollment confirmation and enrollment reminder emails with a couple tweaks according to the spec.
Here are the new emails (I've marked sections purple if their content is different than the spec's because of more recent updates to the emails from this PR (such as changing the "Covid-19" section to the "Health and wellness precautions" section)):
Enrollment confirmation/receipt (in-person)
Enrollment confirmation/receipt (virtual)
Enrollment 10-day reminder (in-person)
Enrollment 10-day reminder (virtual)
Enrollment 3-day reminder (in-person)
Enrollment 3-day reminder (virtual)
Removing session times for CSA Capstone workshops
In
_workshop_logistics.html.haml, they were removed for the CSA Capstone workshops because they will be national and virtual and the workshop dashboard does not localize the time.Here is an example of a non-CSA-Capstone-workshop email with logistics to show that the times still show up for other workshops:
Links
Spec: here
Jira ticket for adding CSA Capstone subject: here
Jira ticket for adding CSA Capstone emails: here
Testing story
Local testing.
PR Checklist: