Bump classnames from 2.2.5 to 2.3.2 - #51211
Merged
Merged
Conversation
breville
reviewed
Apr 7, 2023
breville
approved these changes
Apr 7, 2023
breville
left a comment
breville
left a comment
Member
There was a problem hiding this comment.
Not very familiar with this component, but Music Lab changes look fine. Thanks!
sanchitmalhotra126
approved these changes
Apr 7, 2023
sanchitmalhotra126
left a comment
sanchitmalhotra126
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump classnames from 2.2.5 to 2.3.2
Simple bump of
classnameslib version.No breaking changes intended, just a small improvement for Typescript dev experience. (In this version lib has types for TS, previously it didn't have them)
Now we can use
import classNames from "classnames";instead ofconst classNames = require('classnames');Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: