Add steps to wait until pages load to (hopefully) reduce flakiness - #51204
Merged
bethanyaconnor merged 1 commit intoApr 10, 2023
Conversation
rshipp
approved these changes
Apr 10, 2023
hannahbergam
approved these changes
Apr 10, 2023
hannahbergam
left a comment
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
TIL about the levelbuilder version of steps.rb. Thanks for this!
| # On last level of the lesson | ||
| And I am on "http://studio.code.org/s/csp3-2019/lessons/3/levels/1" | ||
| And I click selector ".submitButton" | ||
| And I wait until I am on "http://studio.code.org/s/csp3-2019" |
Contributor
There was a problem hiding this comment.
Curious about the difference between this line and the line below. Excited to see if it helps!
Contributor
Author
There was a problem hiding this comment.
My theory is that the browser hasn't even tried to load the page yet so the next command was running on the previous page (and succeeding). 100% speculative though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds steps to wait until pages load to reduce flakiness on a couple of tests that are sitting on our flakiness threshold. See this Slack message; unfortunately, I don't have a great idea for the flakiest test in the list.
Failing run for the data docs test: https://app.saucelabs.com/tests/4cb268509f9d48168cb46e7332ce854d#72
Failing run for the end-of-lesson test: https://app.saucelabs.com/tests/ccaa79c2574948af8fe77d816f587c10#21