Adding feature flag for the CPA compliance project - #51195
Merged
Conversation
wilkie
reviewed
Apr 7, 2023
| # @param schedule [Map] A map of the CPA phases to dates. Example: | ||
| # { | ||
| # “new_user_lockout”: “2023-07-01T00:00:00Z”, | ||
| # “all_user_lockout”: “2024-07-01T00:00:00Z” |
Contributor
There was a problem hiding this comment.
something ate the whitespace here I think, if that bothers you at all
wilkie
approved these changes
Apr 7, 2023
wilkie
left a comment
wilkie
left a comment
Contributor
There was a problem hiding this comment.
lgtm! I appreciate how thorough the documentation here is. I didn't consider that an experiment value could be a dictionary.
Thanks for doing this. I'll build off of it as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helper method
cpa_experiencewhich returns the current phase of our Colorado Privacy Act (CPA) compliance. It also adds support for query string and cookie overrides so we can manually test the different phases before going live.Links
Testing story