Align cdoFieldImageDropdown columns with field_rectangular_dropdown - #51189
Merged
Conversation
bencodeorg
approved these changes
Apr 6, 2023
fisher-alice
reviewed
Apr 7, 2023
| : Math.floor(Math.sqrt(initialOptions.length)); | ||
| const numColumns = Math.max( | ||
| 4, | ||
| Math.floor(Math.sqrt(initialOptions.length)) |
Contributor
There was a problem hiding this comment.
Just curious - is it a standard practice to compute the # of cols using Math.sqrt?
Contributor
Author
There was a problem hiding this comment.
We are doing that to keep it approximately square shaped. Logic in the cdo-block repo that I am reproducing is here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently updated the blockly repo to calculate the number of columns in a field_rectangular_dropdown (for example, the backgrounds dropdown): https://github.com/code-dot-org/blockly/pull/308/files . This PR aligns the google blockly version of this to use the same calculation.
(Screenshots include the backgrounds tab experiment turned on)
Before
After
Links
Testing story
Tested locally.
PR Checklist: