Skip to content

Change small-footer to position:fixed in some places #51185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshipp merged 2 commits into from
Apr 10, 2023
Merged

Change small-footer to position:fixed in some places #51185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdc5e3a
Change small-footer to position:fixed for AppLab levels
rshipp Apr 6, 2023
ca5b4f5
Update comment
rshipp Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dashboard/app/assets/stylesheets/application.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,12 @@ $small-footer-standard-width: 400px;
}
}

/* Override footer position on some pages, but not published project views */
#page-small-footer .small-footer-base {

@bethanyaconnor bethanyaconnor Apr 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this doesn't affect the published projects view?

@rshipp rshipp Apr 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That view just doesn't have a #page-small-footer element at all. I checked to see if i could verify that ID was only used in the level show view, but it's actually from a _small_footer.html.haml partial that's conditionally included in application.html.haml, which makes it difficult to tell where else it might actually show up

position: fixed;
}


#copyright-scroll-area {
overflow-y: auto;
padding: 0.8em;
Expand Down