Change small-footer to position:fixed in some places - #51185
Merged
Conversation
rshipp
changed the title
| } | ||
|
|
||
| /* Override footer position on some pages, but not published project views */ | ||
| #page-small-footer .small-footer-base { |
Contributor
There was a problem hiding this comment.
Can you explain why this doesn't affect the published projects view?
Contributor
Author
There was a problem hiding this comment.
That view just doesn't have a #page-small-footer element at all. I checked to see if i could verify that ID was only used in the level show view, but it's actually from a _small_footer.html.haml partial that's conditionally included in application.html.haml, which makes it difficult to tell where else it might actually show up
bethanyaconnor
approved these changes
Apr 10, 2023
Contributor
Author
|
Manually verified all URLs from failing eyes tests are correct with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try another fix for #51166, which was reverted in #51183. I'm not sure this is the best fix, since this
page-small-footerelement is used in multiple places that I don't completely understand.Example Eyes failures:
Sticky when viewing a level (or level summary):
Unchanged when viewing a published project: