Skip to content

Rebrand - Add full-width class to icon bullet list - #51182

Merged
kelbyhawn merged 2 commits into
stagingfrom
rebrand-icon-list-style-update
Apr 11, 2023
Merged

Rebrand - Add full-width class to icon bullet list#51182
kelbyhawn merged 2 commits into
stagingfrom
rebrand-icon-list-style-update

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Adding a .full-width class to the ul.icon-bullet-list element to use when list items need to stretch to the width of the container — example: https://code.org/maker/circuitplayground
Screenshot 2023-04-06 at 1 29 13 PM

The original implementation set the li width at 48% to allow for two columns which needed to be overridden in certain use cases — example: https://code.org/administrators
Screenshot 2023-04-06 at 1 29 24 PM

Note: There are no visual differences being made, just refactoring the code to make it more repeatable on future pages.

Asana task: https://app.asana.com/0/0/1204351318934276

@kelbyhawn
kelbyhawn requested review from a team and levadadenys April 6, 2023 20:31

@levadadenys levadadenys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kelbyhawn
kelbyhawn merged commit 781004a into staging Apr 11, 2023
@kelbyhawn
kelbyhawn deleted the rebrand-icon-list-style-update branch April 11, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants