Add a DCDO flag for testing Puma's out-of-band garbage collection - #51181
Merged
Conversation
Hamms
marked this pull request as ready for review
April 12, 2023 20:13
Contributor
|
Copying from the Warning that's being added to pull request templates soon:
|
cat5inthecradle
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #50886 which verified that the unicorn-specific garbage collection logic we had in place isn't actually having an effect on our memory usage. This is checking the generic garbage collection logic which we are currently using with Puma; this test is much more likely to have an effect than the last one, but given how many Ruby updates we've picked up since it was put it place it very well might not.
Deployment strategy
As with the last flag, we should pick a time to flip this flag and closely monitor the impact on frontend server memory usage.
Follow-up work
If it does turn out we don't need this custom garbage collection logic, we should be able to entirely remove our dependency on our custom fork of
gctools