Update deprecating maker app message depending on browser - #51176
Merged
Conversation
molly-moen
approved these changes
Apr 6, 2023
molly-moen
left a comment
molly-moen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR customizes the Maker App Download message on the 'maker/setup' page based on whether the user is on a chromium browser (Chrome, Edge) which supports WebSerial.
Currently, if a user is on a non-Chromium browser, they don't see the WebSerial option but the message above the 'Download Code.org Maker App' button refer to 'webSerial (instructions above)'. The user is also not informed to use a Chromium browser instead to be able to connect directly with their board. See screenshot below
BEFORE update:
Now if a user is on a non-Chromium browser, they will see the following message: 'We highly recommend using the Chrome or Edge web browser so that you can directly connect to your Circuit Playground or micro:bit using WebSerial. Because your current browser does not support directly connecting to your board, you can download the Maker App as an alternate way to use the Maker Toolkit.'
Whether the user is on a Chromium or non-Chromium browser, they will see a message that support the Maker app will be ending in June 2023 with. a link to the support article about the deprecation of the app.
Video AFTER update:
deprecate-maker.mp4
Links
Slack discussion
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: