adding guardrails for non-existent ml playground files - #51164
Merged
Conversation
nicklathe
approved these changes
Apr 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync out fails in the distribution of content with the following error:
Sync out failed from the error: Errno::ENOENT: No such file or directory @ rb_sysopen - apps/i18n/mlPlayground/sm_ws.jsonThis is trigger by adding samoan to the supported languages.
This PR adds guardrails to the sync-out, checking if the ml-playground file, for a locale exists, before reading the file, and returning an empty Hash otherwise.
Links
Testing story
Ran sync in test server and successfully included Samoan for ml-playground strings.
Deployment strategy
This PR does not have any effect in the Deployment.