Enforce allow multiple attempts for contained levels - #51136
Merged
bethanyaconnor merged 6 commits intoApr 12, 2023
Merged
Conversation
bethanyaconnor
marked this pull request as ready for review
April 7, 2023 13:44
…w_multiple_attempts
bethanyaconnor
deleted the
bethany/cfu/contained-levels-enforce-allow_multiple_attempts
branch
April 12, 2023 12:28
bethanyaconnor
added a commit
that referenced
this pull request
Apr 12, 2023
This reverts commit 6abe34f.
This was referenced Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR for TEACH-301. This PR enforces
allow_multiple_attemptson contained levels only. That setting is enforced on both Multi and FreeResponse contained levels.This PR's diff looks scarier than it is. I added two more contained levels to
allthethings(for four new levels total) to test these new scenarios. These levels were all cloned from other levels inallthethings, with onlyallow_multiple_attemptsbeing changed. I expect eyes diffs due to these new levels.