[Student Learingn] [SL-587, A11Y-121] Update Button.jsx, Get rid of __useDeprecatedTag in DropdownButton.jsx - #51134
Merged
Merged
Conversation
* DropdownButton.js is now a button, not a clickable div
levadadenys
changed the title
levadadenys
marked this pull request as ready for review
April 5, 2023 13:37
Contributor
|
Looks like this causes some vertical shifting for the inline
Compare with the old version:
Ideally the buttons would be vertically centered with the text, but I think I did some manual pixel offsets here because I was having trouble getting that to work. |
* fix ResourceList.jsx dropDown padding positioning
Contributor
Author
Nice catch, thank you! |
bencodeorg
approved these changes
Apr 7, 2023
bethanyaconnor
approved these changes
Apr 7, 2023
Contributor
|
Merging for Denys |
8 tasks
levadadenys
added a commit
that referenced
this pull request
Apr 11, 2023
…sx, Get rid of __useDeprecatedTag in DropdownButton.jsx"" (#51240) * Revert "Revert "[Student Learingn] [SL-587, A11Y-121] Update Button.jsx, Get rid of __useDeprecatedTag in DropdownButton.jsx (#51134)" (#51216)" This reverts commit d80ce8f. * fix javalab return to my project button * *TeacherDasboardHeader - fix margin-bottom for header buttons back to original size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Student Learingn] [SL-587, A11Y-121] Update Button.jsx, Get rid of __useDeprecatedTag in DropdownButton.jsx
We need to carefully merge this PR and check if nothing is broken. If all is ok - we have a quick way to get rid of clickable divs.
useDefaultLineHeightprop is needed to set line height from initial button module styles. In this particular case - we need that prop because parent element ofDropdonButton.jsxisdisplay: inline-block;and previous lineHeight is not working properly for that case.Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: