Fixing teacherViewingStudentWork is undefined in topinstructions component - #51118
Merged
Conversation
vijayamanohararaj
force-pushed
the
vijaya/top_instructions_undefined
branch
from
April 6, 2023 03:35
9a12e60 to
2cf25b4
Compare
vijayamanohararaj
marked this pull request as ready for review
April 6, 2023 15:45
bethanyaconnor
approved these changes
Apr 6, 2023
bethanyaconnor
left a comment
bethanyaconnor
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All our drone builds hit this issue resulting in noise when trying to root cause build failures for daily deployments.
JIRA ticket: https://codedotorg.atlassian.net/browse/TEACH-388?atlOrigin=eyJpIjoiMzkxMGJhOWNkMGU1NGMyY2JhODBjZDdjNDEzYmQ4OWUiLCJwIjoiamlyYS1zbGFjay1pbnQifQ
Testing story
Outside of unit tests, manually sanity tested scenarios around viewing course page as teacher
PR Checklist: