Enable load balancer slow start - #51105
Merged
Merged
Conversation
sureshc
changed the title
Hamms
approved these changes
Apr 4, 2023
Hamms
left a comment
Hamms
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Seems like something that would be valuable to have enabled even if we weren't having issues that it directly addresses
sureshc
added a commit
that referenced
this pull request
Apr 10, 2023
* Fix a Few More `Using the last argument as keyword parameters is deprecated` Warnings * update Spring to 3.1.1 * Enable load balancer slow start. (#51105) --------- Co-authored-by: Elijah Hamovitz <elijahhamovitz@gmail.com> Co-authored-by: suresh <suresh@code.org>
sureshc
added a commit
that referenced
this pull request
Apr 11, 2023
sureshc
added a commit
that referenced
this pull request
Apr 19, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable a 120 second slow start to reduce the likelihood of performance issues when releasing to production during peak usage time periods.
https://codedotorg.atlassian.net/browse/INF-864
Links
Testing story
Our managed test environment provisions a load balancer, but does not have an Auto Scaling Group implemented, so no new "Front End" (web application server) EC2 Instances will be provisioned on our managed test server when this change reaches that environment, so this feature will not be exercised until it reaches production.
We could provision an adhoc with the
Full Stack(auto scaling, load balancer, RDS database, etc.) enabled, but we have not been successful in getting those to provision lately, and also if we pushed a new commit to this feature branch to simulate a production release, a longstanding limitation in our adhoc provisioning logic, we re-provision the entire stack as a single EC2 Instance environment (no CloudFront, no load balancer, no auto scaling group, no RDS cluster, etc.).Deployment strategy
Possibly release as a 2nd production deploy later in the work day to minimize risk.
Follow-up work
Privacy
Security
Caching
PR Checklist: