remove unnecessary condition - #51039
Merged
Merged
Conversation
Hamms
reviewed
Apr 6, 2023
Hamms
left a comment
Hamms
left a comment
Contributor
There was a problem hiding this comment.
Do we understand why this condition was added in the first place, and/or what value we DO expect s3:delimiter to have?
Contributor
Author
|
I added this with the initial creation of the role, and I think we're just looking at a mistaken copy paste from the previously manually created Contributor roles. These have been deleted, so I can't reference them to confirm, nor would I have much in terms of context for why. I also don't have any certainty that the previous roles were completely working. I can't think of a reason why this condition would be useful. The condition effectively scopes access to the relevant prefixes (folders). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a problematic condition on the ListBuckets and ListBucketVersions actions.
Links
Testing story
As these permissions are additive, I was able to add a new policy to the contributor with the correct ListBucketVersions policy. With this policy applied, the following command was successful.
Before - reproducing the problem:
After applying manual policy, the versions are listed.
Deployment strategy
list-object-versionscommandsSecurity
Action remains scoped to the appropriate prefixes
PR Checklist:
Tests provide adequate coverageNew features are translatable or updates will not break translations