Fix a Few More Using the last argument as keyword parameters is deprecated Warnings - #50999
Merged
Hamms merged 1 commit intoApr 10, 2023
Merged
Conversation
Hamms
added
the
Ruby Update
Hamms
marked this pull request as ready for review
March 29, 2023 17:10
sureshc
approved these changes
Apr 10, 2023
sureshc
left a comment
sureshc
left a comment
Contributor
There was a problem hiding this comment.
Is it bad that I wrote most of the method calls that are being updated here? 😬
Contributor
Author
|
Lol, nah; my understanding is that this invocation pattern is being deprecated because of how difficult it was for the Ruby team to continue to support the syntax in a consistent way, not because there was any problem with developers using it. See Why we’re deprecating the automatic conversion from the documentation linked in the linked PR for more context |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for an update to Ruby 3.x; see #49447 for more context.