Skip to content

Update Summer Workshop emails - #50991

Merged
TurnerRiley merged 6 commits into
stagingfrom
update-summer-workshop-emails
Apr 7, 2023
Merged

Update Summer Workshop emails#50991
TurnerRiley merged 6 commits into
stagingfrom
update-summer-workshop-emails

Conversation

@TurnerRiley

@TurnerRiley TurnerRiley commented Mar 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

All the details for email updates are in this spec. There is one new email to add for CSA this year (it's the very first one in the doc) which is in a separatae PR. All the other updates to the existing emails are in this PR.

Here is a list of the main changes to each version of the emails:

Teacher Enrollment Reminder email

All versions of the teacher enrollment reminder email received these changes:

Here are the changes specific to a/some version(s) of the email:

Email name Sections updated Screenshots
teacher_enrollment_reminder__csa_summer_workshop_10_day Replace covid_19 section with Health and wellness precautions section, and add CSA-specific Before the Workshop section SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csa_summer_workshop_3_day Same as above SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csa_summer_workshop_10_day_virtual Simplify virtual_tips section SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csa_summer_workshop_3_day_virtual Same as above SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csd_summer_workshop_10_day Replace covid_19 section with Health and wellness precautions section, and add Non-CSA-specific Before the Workshop section SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csd_summer_workshop_3_day Same as above SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csd_summer_workshop_10_day_virtual Simplify virtual_tips section and add Non-CSA-specific Before the Workshop section SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csd_summer_workshop_3_day_virtual Same as above SS
teacher_enrollment_reminder__csp_summer_workshop_10_day Replace covid_19 section with Health and wellness precautions section, and add Non-CSA-specific Before the Workshop section SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csp_summer_workshop_3_day Same as above SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csp_summer_workshop_10_day_virtual Simplify virtual_tips section and add Non-CSA-specific Before the Workshop section SS_top_half, SS_bottom_half
teacher_enrollment_reminder__csp_summer_workshop_3_day_virtual Same as above SS

Facilitator Post-Workshop CSP Summer email

Email name Sections updated Screenshots
facilitator_post_workshop_csp_summer Remove travel reimbursement section SS

Facilitator Pre-Workshop emails

Email name Sections updated Screenshots
facilitator_pre_workshop_csp, facilitator_pre_workshop_csd, and facilitator_pre_workshop_csa Update Facilitator Tools Guide link Sample SS

Links

Jira ticket: here
Spec: here

Testing story

Local testing using the mailer previews.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@TurnerRiley
TurnerRiley requested a review from a team March 29, 2023 18:47
megcrenshaw
megcrenshaw reviewed Mar 30, 2023
View reviewed changes

@megcrenshaw megcrenshaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the screenshots, Turner! One small difference I noticed: I don't see the Before the Workshop section for the CSA virtual workshop reminders (3 and 10 day). It looks like there's a rather hard-to-see conditional for that. Otherwise, this looks great! Thanks for making this easy to review.

@TurnerRiley

TurnerRiley commented Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the screenshots, Turner! One small difference I noticed: I don't see the Before the Workshop section for the CSA virtual workshop reminders (3 and 10 day). It looks like there's a rather hard-to-see conditional for that. Otherwise, this looks great! Thanks for making this easy to review.

Thank you for catching this! In the original spec it was present in all CSA emails but only non-virtual for CSD and CSP so I got the logic wrong. I checked with Dani and she said we should probably just have that section in each email (which is how it's been updated now, as well as the associated screenshots)!

@TurnerRiley
TurnerRiley requested review from a team and megcrenshaw April 5, 2023 17:05
megcrenshaw
megcrenshaw approved these changes Apr 6, 2023
View reviewed changes

@megcrenshaw megcrenshaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making this easy to review

@TurnerRiley
TurnerRiley merged commit a1679f8 into staging Apr 7, 2023
@TurnerRiley
TurnerRiley deleted the update-summer-workshop-emails branch April 7, 2023 16:55
@TurnerRiley TurnerRiley mentioned this pull request Apr 7, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@megcrenshaw megcrenshaw megcrenshaw approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TurnerRiley @megcrenshaw