Add a Temporary DCDO Flag for Unicorn-Specific Middleware - #50886
Merged
Conversation
So we can evaluate whether or not we still benefit from it without needing a new build. See thread at https://codedotorg.slack.com/archives/C03CK49G9/p1679344334036199 for more context
Hamms
marked this pull request as ready for review
March 22, 2023 19:12
Hamms
added
the
Ruby Update
sureshc
reviewed
Mar 30, 2023
| # evaluate whether or not this still has a performance impact now that we're no | ||
| # longer using unicorn. | ||
| # TODO: either remove the flag or this entire block, depending on the results | ||
| unless DCDO.get('oobgc_unicorn_middleware_disabled', false) |
Contributor
There was a problem hiding this comment.
Do we typically use Gatekeeper for boolean (“feature flag”) decisions, and DCDO more for configuration settings that have numeric or string datatypes? This should work either way.
Contributor
Author
There was a problem hiding this comment.
We typically use Gatekeeper for the more advanced query logic it provides, which allows us to conditionally enable or disable things based on request parameters. It's also generally a lot more complex; DCDO is the simple option, and is more applicable for these kind of global config options
sureshc
approved these changes
Mar 30, 2023
This was referenced Apr 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can evaluate whether or not we still benefit from it without needing a new build.
Links
See thread at https://codedotorg.slack.com/archives/C03CK49G9/p1679344334036199 for more context
Testing story
Tested locally with a
putsstatement to verify that this block can successfully be turned on and off.Follow-up work
Once this is in production, we should at some point prior to a daily peak flip this flag and restart the web application services so we can check the effects on frontend memory usage.