Remove unicorn gem - #50744
Merged
Merged
Conversation
Hamms
added
the
Ruby Update
Hamms
marked this pull request as ready for review
April 10, 2023 18:25
…implicitly installing it anymore now that unicorn is gone
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another pass at #48143, required for the update to Ruby 3 since
unicornonly supports Ruby 2.Follow-up to #50886, which verified that we aren't using any unicorn-specific functionality anymore, #50854 which removed another dependency which itself depended on unicorn, and #50745 which removes some unused unicorn config files.
Testing story
Monitored frontend EC2 server memory usage in CloudWatch before and after flipping the
oobgc_unicorn_middleware_disabledflag; saw no change. Otherwise relying on existing tests to verify that this doesn't affect any existing part of our system.