Skip to content

Stop Using Deprecated bundle --without - #49961

Merged
Hamms merged 2 commits into
stagingfrom
stop-using-deprecated-bundle-without
Feb 14, 2023
Merged

Stop Using Deprecated bundle --without#49961
Hamms merged 2 commits into
stagingfrom
stop-using-deprecated-bundle-without

Conversation

@Hamms

@Hamms Hamms commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

Specifically, address the following deprecation warning:

[DEPRECATED] The --without flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use bundle config set --local without 'development production adhoc staging levelbuilder integration', and stop using this flag

Also added a new run_bundle_command helper method, to DRY up the new approach a bit

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Hamms added 2 commits January 26, 2023 15:47
Specifically, address the following deprecation warning:

> [DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local without 'development production adhoc staging levelbuilder integration'`, and stop using this flag
@Hamms
Hamms marked this pull request as ready for review January 27, 2023 21:20
@Hamms
Hamms requested review from a team January 27, 2023 21:20
@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label Feb 7, 2023
@Hamms
Hamms merged commit 3c6df4f into staging Feb 14, 2023
@Hamms
Hamms deleted the stop-using-deprecated-bundle-without branch February 14, 2023 01:22
@Hamms Hamms mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ruby Update Everything related to work to update the version of Ruby our codebase runs on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants