Make maker homepage a unit test instead of storybook - #49418
Merged
Conversation
molly-moen
approved these changes
Dec 13, 2022
fisher-alice
approved these changes
Dec 14, 2022
fisher-alice
left a comment
fisher-alice
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to use a unit test here - I was not sure about this one when I migrated the storybook. Thanks for doing this!
| }; | ||
|
|
||
| shallow(<MakerLanding topCourse={fakeTopCourse} />); | ||
| }); |
Contributor
There was a problem hiding this comment.
Is an assertion not wanted here?
Contributor
Author
There was a problem hiding this comment.
Correct, the "test" in these "it renders" tests is just that it's able to render (ie, shallow doesn't error).
Contributor
There was a problem hiding this comment.
Cool! Would it make sense to add another unit test to check the presence of a notification if included?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on this PR, I saw this component did not have unit tests, but had a Storybook component. I didn't realize that we had migrated this story already to the new Storybook API.
It looks like it was sort of a 50/50 decision to keep this entry, but I think it's more extensible to have a unit test here than a Storybook entry (eg, can now add a unit test confirming the presence of a notification).