Update storybook entries to new API - #49149
Conversation
| } | ||
| ]); | ||
| export default { | ||
| title: 'Buttons/AssignButton', |
There was a problem hiding this comment.
I preserved the title nesting on a previous refactor and got the following comment: #48043 (comment). I ended up removing the title nesting in my final commit. Something to consider here!
There was a problem hiding this comment.
Thanks -- I'll remove!
| export const ScrollableNavigation = () => { | ||
| const links = []; | ||
|
|
||
| for (let i = 0; i < 20; i++) { |
There was a problem hiding this comment.
I can't find a corresponding set of 20 links in the original storybook story. Is this just giving us something to scroll through?
There was a problem hiding this comment.
oh oops, meant to add a comment. the reason I added this is because the old Scrollable navigation test didn't actually have enough tabs to scroll through. So I dynamically added 20 to ensure that we could scroll (like you intuited). I'll add a comment here but also open to suggestions on how to do this better!
There was a problem hiding this comment.
Comment is perfect - I just wanted to make sure I wasn't missing something with this transition!
2 participants
Updates for several components:
AssignButton.story.jsxis refactored as it is reusable and also doesn't have a test covering the render behavior.SectionAssigner.story.jsxis being removed as it isn't testing different scenarios and we have an almost identical "it renders" testSignInInstruction.story.jsxis being refactored as it tests multiple scenarios and doesn't have a test covering the render behaviorTeacherDashboardNavigation.story.jsxis being refactored as it tests a visual scenario and also doesn't have a unit test covering it.TeacherSectionSelector.story.jsxis being refactored as it doesn't have corresponding test coverage (which should change soon!)