Migrate ChallengeDialog story - #49135
Merged
Merged
Conversation
bencodeorg
reviewed
Nov 15, 2022
|
|
||
| export const Starting_Dialog = Template.bind({}); | ||
| Starting_Dialog.args = { | ||
| hideBackdrop: true, |
Contributor
There was a problem hiding this comment.
Maybe out of scope, but could we dedupe some of these props? I think either of the approaches discussed here would work:
Contributor
Author
There was a problem hiding this comment.
Good call, I'll pull the common ones in
| isIntro: true | ||
| }; | ||
|
|
||
| export const Starting_Dialog_with_Large_Avatar = Template.bind({}); |
Contributor
There was a problem hiding this comment.
Nit: are underscores a norm?
Contributor
Author
There was a problem hiding this comment.
Oh hmm, I thought I had seen underscores in an example but looking again I may have been looking at something else. I'll remove to be consistent
maddiedierker
approved these changes
Nov 15, 2022
bencodeorg
approved these changes
Nov 15, 2022
bencodeorg
left a comment
bencodeorg
left a comment
Contributor
There was a problem hiding this comment.
Oh dang, thought there were more shared props. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the ChallengeDialog.story.jsx file
Links
https://codedotorg.atlassian.net/browse/PP-186
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: