Migrate PaginationWrapper story - #49130
Merged
Merged
Conversation
fisher-alice
marked this pull request as ready for review
November 14, 2022 23:22
sanchitmalhotra126
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated PaginationWrapper to new Storybook API:
Screencast video of PaginationWrapper component:
pagination-wrapper-clickable.mp4
When I first migrated this Storybook, I removed the StorybookHarness and created 3 different stories, 1 per page. View version here and screencast video here. However, looking at its props values
currentPageandonChangePage, I saw that changing the current page was integral to the component. Thus, I added the StorybookHarness back in.Links
Refer to this PR for context.
This spreadsheet keeps track of all migrations.
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: