Re-add Storybook entries for ProjectsList - #49129
Conversation
epeach
left a comment
epeach
left a comment
There was a problem hiding this comment.
I agree with your call to remove the story for SectionProjectsList. I left a feed comments on the ProjectsList translation. Let me know if you have any questions!
| ) | ||
| } | ||
| ]); | ||
| const DEFAULT_ARGS = { |
There was a problem hiding this comment.
I'm curious if there is a benefit to having these DEFAULT_ARGS or if we can just put them in the template itself, like
<ProjectsList
projectsData: STUB_PROJECTS_DATA,
studioUrlPrefix: 'https://studio.code.org',
showProjectThumbnails: true
{...args}
/>
There was a problem hiding this comment.
What I had was closer to the Storybook docs, but I like yours better. Updated!
|
|
||
| const Template = args => <ProjectsList {...args} />; | ||
|
|
||
| // Name of export determines what is shown in storybook entry |
There was a problem hiding this comment.
Nope, but with the refactor I now need it. So, now, yes!
There was a problem hiding this comment.
oh nvm, just saw in this PR a similar thing without the linting exception. Turns out my editor was complaining but it committed without issue. Removed!
2 participants
Re-enable a Storybook entry for a component that shows a table of student projects on the teacher dashboard. Remove a entries for a parent component (
SectionProjectsList), which a) has unit tests and b) basically just renders theProjectsListcomponent and a dropdown above it to select a student.Testing story
New Storybook entries:
With Thumbnails
Without Thumbnails