Add edit data doc SaveBar error handling - #48465
Merged
Merged
Conversation
davidsbailey
approved these changes
Oct 5, 2022
davidsbailey
left a comment
davidsbailey
left a comment
Member
There was a problem hiding this comment.
nice fix! it would be great if you could include a screenshot or short screen recording of the save error codepath in action. were you able to trigger the failure path end to end? one way to do this is to go whatever URL the save button is accessing and block it:
pro tip: remember to unblock after! :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging the Add edit DataDoc frontend PR, @annaxuphoto spotted an issue relating to it in the latest test build:
The SaveBar component was expecting an error prop passed in for error handling that wasn't there. This PR adds that in by mirroring the behavior of a similar function in
ReferenceGuideEditor.jsx.Links
Test build with error: here
Edit data docs frontend PR: here
Testing story
Local testing to ensure thrown errors were caught and passed to SaveBar (such as changing the url in the ajax request to a non-existent one).
After ensuring the save button can't access the URL, the error thrown is displayed in the SaveBar (desired behavior):
PR Checklist: