Migrate MakerLanding and ScrollButtons storybooks - #48411
Merged
Conversation
fisher-alice
marked this pull request as ready for review
September 30, 2022 23:34
maddiedierker
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to new Storybook API:
I added another story in ScrollButtons.story.jsx to show ScrollButtons when isMinecraft is assigned true which results in square instead of arrow buttons.
I was also debating about whether to keep MakerLanding, but with possible upcoming work for Maker unit with MicroBit, we may need another landing page for a MicroBit version of the CSD curriculum so decided to keep.
Video of 2 components in Storybook:
storybooks.mp4
Links
Refer to this PR for context.
This spreadsheet keeps track of all migrations.
PR Checklist: