Downgrade grunt-concurrent to last working version - #48377
Merged
Conversation
megcrenshaw
reviewed
Sep 29, 2022
| version "1.5.2" | ||
| resolved "https://registry.yarnpkg.com/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a" | ||
| integrity sha1-7GphrlZIDAw8skHJVhjiCJL5Zyo= | ||
| integrity sha512-nSVgobk4rv61R9PUSDtYt7mPVB2olxNR5RWJcAsH676/ef11bUZwvu7+RGYrYauVdDPcO519v68wRhXQtxsV9w== |
There was a problem hiding this comment.
For my learning –– do you know how it's determined which sha function is used for these? No worries if not
Contributor
Author
There was a problem hiding this comment.
this is kind of a guess based on some light reading, but i think it depends on two things:
- the version of yarn. with yarn 2.0, sha512 became the default, but was available in earlier versions with the unsafe-disable-integrity-migration option
- the sha that the package has available. i don't feel like i really understand this piece 😄 but someone mentions it in this stack overflow. maybe this piece depends on the version of yarn/NPM that the package publisher is using?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48105.
Upgrading
grunt-concurrentbroke the output for the webpack build that displays % building message. This plugin isn't actively developed anymore (the latest version, 3.0.0, was published 3 years ago). I tried downgrading to 2.x.x, but it had the same issue. I did some digging to find whether there was a configuration change or something that's causing this, but couldn't find anything, so I'm downgrading to the last known working version.Now, when you run
yarn start, which runs 2 concurrent watch tasks:code-dot-org/apps/Gruntfile.js
Lines 1228 to 1239 in bed3874
...you see the expected output as the concurrent tasks are building:
Screen.Recording.2022-09-29.at.3.58.18.PM.mov