Skip to content

HoC 2022 - Keep the code.org/learn header the same for pre-hoc - #48311

Merged
kelbyhawn merged 2 commits into
stagingfrom
hoc2022-codeorg-learn-set-pre-hoc-bg
Sep 27, 2022
Merged

HoC 2022 - Keep the code.org/learn header the same for pre-hoc#48311
kelbyhawn merged 2 commits into
stagingfrom
hoc2022-codeorg-learn-set-pre-hoc-bg

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Keep the existing arrows banner on https://code.org/learn during pre-hoc and remove old banner code.

Similar PR: #47959


Before

Screen Shot 2022-09-27 at 8 39 28 AM

After

Screen Shot 2022-09-27 at 8 39 36 AM


@kelbyhawn
kelbyhawn requested a review from breville September 27, 2022 15:48

@breville breville left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that we're likely to encounter it any time soon, if ever, but i'm curious how the remaining code works when we aren't in any of these modes (e.g hoc_mode is null).

@kelbyhawn

Copy link
Copy Markdown
Contributor Author

Not that we're likely to encounter it any time soon, if ever, but i'm curious how the remaining code works when we aren't in any of these modes (e.g hoc_mode is null).

Is there a way I can test this on my localhost?

@kelbyhawn
kelbyhawn merged commit f1e795e into staging Sep 27, 2022
@kelbyhawn
kelbyhawn deleted the hoc2022-codeorg-learn-set-pre-hoc-bg branch September 27, 2022 17:16
@kelbyhawn kelbyhawn added the hoc label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants