store studentNames state as string rather than array - #48181
Merged
Conversation
davidsbailey
marked this pull request as ready for review
September 20, 2022 02:40
bethanyaconnor
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #48126. Fixes the following bug:
Screen.Recording.2022-09-19.at.2.11.03.PM.mov
Testing story
I didn't write a test for this exact scenario, but the new implementation reduces the amount of complexity and makes me feel like the existing test cases now cover all of the possibilities pretty well:
I did also manually verify that typing in a student name and then deleting it does not crash the page.