Styling updates to Lock Dialog - #48150
Merged
Merged
Conversation
bethanyaconnor
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates formatting of the two error messages so that the hidden warning doesn't require additional space unless it's displayed, and adding a buffer to the empty save error message so it's not up against the buttons.
(space removed from top where hidden error message goes)
A part two from this task:
https://codedotorg.atlassian.net/browse/LP-1401
A follow up from this PR:
#48078
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: